feat(generate-spec): Support controllers in sub-directories #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
commented
May 12, 2025
Signed-off-by: provokateurin <[email protected]>
provokateurin
force-pushed
the
feat/generate-spec/sub-dir-controllers
branch
from
e5e9d6f to
0e8d6d3
Compare
come-nc
approved these changes
May 13, 2025
| ['name' => 'Settings#deprecatedRouteAndParameterGet', 'url' => '/api/{apiVersion}/deprecated-route-parameter-get', 'verb' => 'GET', 'requirements' => ['apiVersion' => '(v2)']], | ||
| ['name' => 'Settings#samePathGet', 'url' => '/api/{apiVersion}/same-path', 'verb' => 'GET', 'requirements' => ['apiVersion' => '(v2)']], | ||
| ['name' => 'Settings#samePathPost', 'url' => '/api/{apiVersion}/same-path', 'verb' => 'POST', 'requirements' => ['apiVersion' => '(v2)']], | ||
| ['name' => 'V1\SubDir#subDirRoute', 'url' => '/sub-dir', 'verb' => 'GET'], |
Member
There was a problem hiding this comment.
Windows style paths in the name?
Member
There was a problem hiding this comment.
I wasn't even aware that subfolders worked
Member
Author
There was a problem hiding this comment.
I wasn't even aware that subfolders worked
Me neither until yesterday 🙈
Windows style paths in the name?
No, it's the backslash from the namespace. Routes never operate based on the path but the namespace (but of course those are very closely related with PSR-4).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to support https://github.com/nextcloud/end_to_end_encryption/tree/master/lib/Controller/V1