fix(ControllerMethod): Log an error if return statements are detected but no @return annotation is present #234
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already log an error if no response is returned from a controller method, but that is also satisfied if a
@throwsannotation is present.Luckily with the return statements we can easily check if any is present (there might be controller methods that only throw or never return), so a separate error is now logged in case the code has a
returnstatement but no@returnannotation.