fix: Add 401 response for non-public pages and 403 response for admin pages #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: provokateurin <[email protected]>
provokateurin
force-pushed
the
fix/non-public-page-401-response
branch
from
e3ae61b to
65eab06
Compare
provokateurin
commented
Aug 21, 2025
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
… pages Signed-off-by: provokateurin <[email protected]>
provokateurin
force-pushed
the
fix/non-public-page-401-response
branch
from
e390954 to
9acc49b
Compare
provokateurin
changed the title
nickvergessen
approved these changes
Aug 26, 2025
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
👍
Could additionally add 429 when ratelimit or bfp is there, ref
https://nextcloud-talk.readthedocs.io/en/latest/global/
Member
Author
|
Yes, but that will be part of #151, since it needs annotation/attribute parsing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
401/403 might be returned by the SecurityMiddleware, so they are not directly documented for each endpoint (except through the annotations/attributes), so they need to be added manually.