Skip to content

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Dec 1, 2023

These are all missing codes I found in default/supported apps

@provokateurin
Copy link
Member

LGTM, but could you maybe add all the ones found in https://github.com/nextcloud/server/blob/master/lib/public/AppFramework/Http.php while you are at it?

I wonder if there is a smarter way to do this, maybe by adding OCP as a dependency and iterating all the constants?

@nickvergessen
Copy link
Member Author

maybe by adding OCP as a dependency and iterating all the constants?

The nextcloud/OCP package could be handy with that.
Then again, if we wouldn't look at strings but PHP code that'd be much simpler, same with all the other type things 🙈

Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen force-pushed the bugfix/noid/add-more-status branch from 20e5ffd to e1b742b Compare December 1, 2023 16:29
@nickvergessen
Copy link
Member Author

Added all by copy-pasting the block and then replacing:

  • public const with "
  • = with " =>
  • ; with ,

@nickvergessen nickvergessen merged commit 16c27a1 into main Dec 1, 2023
@delete-merged-branch delete-merged-branch bot deleted the bugfix/noid/add-more-status branch December 1, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants