fix(OpenApiType): Resolve refs for parameters to check if they are serializable - #383
Merged
Merged
Conversation
…rializable Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
force-pushed
the
fix/openapitype/resolve-refs-for-parameters
branch
from
September 2, 2026 08:16
cab96a4 to
8e35176
Compare
CarlSchwan
reviewed
Sep 2, 2026
CarlSchwan
approved these changes
Sep 2, 2026
Member
Author
|
Somehow https://github.com/nextcloud/openapi-extractor/actions/runs/33607825312/job/100175805613?pr=383 shows no diff for server, even though I was expecting some. It seems like this fix doesn't cover the cases in the sharing app yet. |
provokateurin
marked this pull request as draft
September 2, 2026 09:39
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
marked this pull request as ready for review
September 2, 2026 09:48
provokateurin
enabled auto-merge
September 2, 2026 09:48
provokateurin
disabled auto-merge
September 2, 2026 09:48
Member
Author
|
Now the expected diff is visible: https://github.com/nextcloud/openapi-extractor/actions/runs/33616118603/job/100202221007?pr=383 |
provokateurin
deleted the
fix/openapitype/resolve-refs-for-parameters
branch
September 2, 2026 10:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #380
Before this we were refusing to check if a query parameter was serializable if it had a ref, even though the type behind the ref might be serializable. Now the refs are recursively resolved to check if the parameter is serializable.