feat(settings): conditionally display developer documentation link based on configuration

Signed-off-by: Arsalan Ul Haq Sohni <[email protected]>

Author: Arsalanulhaq

apps/settings/lib/Controller/AppSettingsController.php

@@ -92,7 +92,12 @@ public function viewApps(): TemplateResponse {
 
 		$this->initialState->provideInitialState('appstoreEnabled', $this->config->getSystemValueBool('appstoreenabled', true));
 		$this->initialState->provideInitialState('appstoreBundles', $this->getBundles());
-		$this->initialState->provideInitialState('appstoreDeveloperDocs', $this->urlGenerator->linkToDocs('developer-manual'));
+
+		// Conditionally set developer docs link based on configuration
+		$displayDocumentationLink = $this->config->getAppValue('settings', 'display_documentation_link', 'true') === 'true';
+		$developerDocsUrl = $displayDocumentationLink ? $this->urlGenerator->linkToDocs('developer-manual') : '';
+		$this->initialState->provideInitialState('appstoreDeveloperDocs', $developerDocsUrl);
+
 		$this->initialState->provideInitialState('appstoreUpdateCount', count($this->getAppsWithUpdates()));
 
 		if ($this->appManager->isEnabledForAnyone('app_api')) {

apps/settings/src/views/AppStoreNavigation.vue

@@ -101,6 +101,7 @@
 			</template>
 
 			<NcAppNavigationItem
+				v-if="developerDocsUrl"
 				id="app-developer-docs"
 				:name="t('settings', 'Developer documentation ↗')"
 				:href="developerDocsUrl" />

apps/settings/tests/Controller/AppSettingsControllerTest.php

@@ -164,6 +164,11 @@ public function testViewApps(): void {
 			->method('getSystemValueBool')
 			->with('appstoreenabled', true)
 			->willReturn(true);
+		$this->config
+			->expects($this->once())
+			->method('getAppValue')
+			->with('settings', 'display_documentation_link', 'true')
+			->willReturn('true');
 		$this->navigationManager
 			->expects($this->once())
 			->method('setActiveEntry')
@@ -209,6 +214,11 @@ public function testViewAppsAppstoreNotEnabled(): void {
 			->method('getSystemValueBool')
 			->with('appstoreenabled', true)
 			->willReturn(false);
+		$this->config
+			->expects($this->once())
+			->method('getAppValue')
+			->with('settings', 'display_documentation_link', 'true')
+			->willReturn('true');
 		$this->navigationManager
 			->expects($this->once())
 			->method('setActiveEntry')
@@ -254,6 +264,11 @@ public function testDeveloperDocumentationLinkIsProvided(): void {
 			->method('getSystemValueBool')
 			->with('appstoreenabled', true)
 			->willReturn(true);
+		$this->config
+			->expects($this->once())
+			->method('getAppValue')
+			->with('settings', 'display_documentation_link', 'true')
+			->willReturn('true');
 		$this->navigationManager
 			->expects($this->once())
 			->method('setActiveEntry')
@@ -297,6 +312,11 @@ public function testDeveloperDocumentationLinkWithDifferentUrls(string $expected
 			->method('getSystemValueBool')
 			->with('appstoreenabled', true)
 			->willReturn(true);
+		$this->config
+			->expects($this->once())
+			->method('getAppValue')
+			->with('settings', 'display_documentation_link', 'true')
+			->willReturn('true');
 		$this->navigationManager
 			->expects($this->once())
 			->method('setActiveEntry')
@@ -332,4 +352,88 @@ public function developerDocsUrlProvider(): array {
 			'with anchor' => ['https://docs.nextcloud.com/server/latest/developer_manual/#getting-started'],
 		];
 	}
+
+	public function testDeveloperDocumentationLinkHiddenWhenConfigured(): void {
+		$this->installer->expects($this->any())
+			->method('isUpdateAvailable')
+			->willReturn(false);
+		$this->bundleFetcher->expects($this->once())->method('getBundles')->willReturn([]);
+		$this->config
+			->expects($this->once())
+			->method('getSystemValueBool')
+			->with('appstoreenabled', true)
+			->willReturn(true);
+		$this->config
+			->expects($this->once())
+			->method('getAppValue')
+			->with('settings', 'display_documentation_link', 'true')
+			->willReturn('false');
+		$this->navigationManager
+			->expects($this->once())
+			->method('setActiveEntry')
+			->with('core_apps');
+
+		// When display_documentation_link is false, linkToDocs should not be called
+		$this->urlGenerator
+			->expects($this->never())
+			->method('linkToDocs');
+
+		$providedStates = [];
+		$this->initialState
+			->expects($this->exactly(4))
+			->method('provideInitialState')
+			->willReturnCallback(function ($key, $value) use (&$providedStates) {
+				$providedStates[$key] = $value;
+			});
+
+		$this->appSettingsController->viewApps();
+
+		// Assert that the developer docs state was provided with an empty string
+		$this->assertArrayHasKey('appstoreDeveloperDocs', $providedStates);
+		$this->assertEquals('', $providedStates['appstoreDeveloperDocs']);
+	}
+
+	public function testDeveloperDocumentationLinkShownByDefault(): void {
+		$this->installer->expects($this->any())
+			->method('isUpdateAvailable')
+			->willReturn(false);
+		$this->bundleFetcher->expects($this->once())->method('getBundles')->willReturn([]);
+		$this->config
+			->expects($this->once())
+			->method('getSystemValueBool')
+			->with('appstoreenabled', true)
+			->willReturn(true);
+		$this->config
+			->expects($this->once())
+			->method('getAppValue')
+			->with('settings', 'display_documentation_link', 'true')
+			->willReturn('true');
+		$this->navigationManager
+			->expects($this->once())
+			->method('setActiveEntry')
+			->with('core_apps');
+
+		$developerDocsUrl = 'https://docs.nextcloud.com/server/latest/developer_manual/';
+
+		// When display_documentation_link is true (default), linkToDocs should be called
+		$this->urlGenerator
+			->expects($this->once())
+			->method('linkToDocs')
+			->with('developer-manual')
+			->willReturn($developerDocsUrl);
+
+		$providedStates = [];
+		$this->initialState
+			->expects($this->exactly(4))
+			->method('provideInitialState')
+			->willReturnCallback(function ($key, $value) use (&$providedStates) {
+				$providedStates[$key] = $value;
+			});
+
+		$this->appSettingsController->viewApps();
+
+		// Assert that the developer docs state was provided with the correct URL
+		$this->assertArrayHasKey('appstoreDeveloperDocs', $providedStates);
+		$this->assertEquals($developerDocsUrl, $providedStates['appstoreDeveloperDocs']);
+	}
 }