feat(theming): allow to disable standalone windows

Co-authored-by: Ferdinand Thiessen <[email protected]> Signed-off-by: Simon L. <[email protected]> [skip ci]
nextcloud · Feb 6, 2025 · 5efeb92 · 5efeb92
1 parent de83b2c
commit 5efeb92
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/apps/theming/lib/Controller/ThemingController.php b/apps/theming/lib/Controller/ThemingController.php
@@ -506,7 +506,7 @@ public function getManifest(string $app): JSONResponse {
 						'sizes' => '16x16'
 					]
 				],
-			'display' => 'standalone'
+			'display' => $this->config->getSystemValueBool('theming.standalone_window.enabled', true) ? 'standalone' : 'browser'
 		];
 		$response = new JSONResponse($responseJS);
 		$response->cacheFor(3600);

diff --git a/apps/theming/tests/Controller/ThemingControllerTest.php b/apps/theming/tests/Controller/ThemingControllerTest.php
@@ -772,7 +772,7 @@ public function testGetManifest() {
 						'sizes' => '16x16'
 					]
 				],
-			'display' => 'standalone',
+			'display' => $standalone ? 'standalone' : 'browser',
 			'short_name' => 'Nextcloud',
 			'theme_color' => null,
 			'background_color' => null,

diff --git a/config/config.sample.php b/config/config.sample.php
@@ -1984,6 +1984,14 @@
  */
 'enforce_theme' => '',
 
+
+/**
+ * This setting allows to disable the PWA functionality that allows browsers to open web applications in dedicated windows.
+ *
+ * Defaults to ``true``
+ */
+'theming.standalone_window.enabled' => true,
+
 /**
  * The default cipher for encrypting files. Currently supported are:
  *  - AES-256-CTR