fix(apps): Remove jobs when an app gets disabled

Signed-off-by: Josh Richards <[email protected]>
nextcloud · Feb 6, 2025 · c5257fe · c5257fe
1 parent f9c03f7
commit c5257fe
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/lib/private/App/AppManager.php b/lib/private/App/AppManager.php
@@ -672,6 +672,7 @@ public function disableApp($appId, $automaticDisabled = false): void {
 		$appData = $this->getAppInfo($appId);
 		if (!is_null($appData)) {
 			\OC_App::executeRepairSteps($appId, $appData['repair-steps']['uninstall']);
+			\OC_App::removeBackgroundJobs($appData['background-jobs']);
 		}
 
 		$this->dispatcher->dispatchTyped(new AppDisableEvent($appId));

diff --git a/lib/private/legacy/OC_App.php b/lib/private/legacy/OC_App.php
@@ -755,6 +755,13 @@ public static function executeRepairSteps(string $appId, array $steps) {
 		$r->run();
 	}
 
+	public static function removeBackgroundJobs(array $jobs) {
+		$queue = \OC::$server->getJobList();
+		foreach ($jobs as $job) {
+			$queue->remove($job);
+		}
+	}
+
 	public static function setupBackgroundJobs(array $jobs) {
 		$queue = \OC::$server->getJobList();
 		foreach ($jobs as $job) {