Skip to content

Commit

Permalink
Merge pull request #50735 from nextcloud/bugfix/noid/bump-php-depende…
Browse files Browse the repository at this point in the history
…ncy-update-versions

fix(setupcheck): Update setup check for PHP version to be more accurate
  • Loading branch information
susnux authored Feb 10, 2025
2 parents 402f512 + 0a6eeb4 commit dda2275
Showing 1 changed file with 12 additions and 1 deletion.
13 changes: 12 additions & 1 deletion apps/settings/lib/SetupChecks/PhpOutdated.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@
use OCP\SetupCheck\SetupResult;

class PhpOutdated implements ISetupCheck {
public const DEPRECATED_PHP_VERSION = '8.1';
public const DEPRECATED_SINCE = '30';
public const FUTURE_REQUIRED_PHP_VERSION = '8.2';
public const FUTURE_REQUIRED_STARTING = '32';

public function __construct(
private IL10N $l10n,
) {
Expand All @@ -29,7 +34,13 @@ public function getName(): string {

public function run(): SetupResult {
if (PHP_VERSION_ID < 80200) {
return SetupResult::warning($this->l10n->t('You are currently running PHP %s. PHP 8.1 is now deprecated in Nextcloud 30. Nextcloud 31 may require at least PHP 8.2. Please upgrade to one of the officially supported PHP versions provided by the PHP Group as soon as possible.', [PHP_VERSION]), 'https://secure.php.net/supported-versions.php');
return SetupResult::warning($this->l10n->t('You are currently running PHP %1$s. PHP %2$s is deprecated since Nextcloud %3$s. Nextcloud %4$s may require at least PHP %5$s. Please upgrade to one of the officially supported PHP versions provided by the PHP Group as soon as possible.', [
PHP_VERSION,
self::DEPRECATED_PHP_VERSION,
self::DEPRECATED_SINCE,
self::FUTURE_REQUIRED_STARTING,
self::FUTURE_REQUIRED_PHP_VERSION,
]), 'https://secure.php.net/supported-versions.php');
}
return SetupResult::success($this->l10n->t('You are currently running PHP %s.', [PHP_VERSION]));
}
Expand Down

0 comments on commit dda2275

Please sign in to comment.