Skip to content

Conversation

@PVince81
Copy link
Member

Add optional size field for the file rich object definition.

For nextcloud/spreed#4472 but could be useful later also.

Add optional size field for the file rich object definition.

Signed-off-by: Vincent Petry <[email protected]>
@faily-bot
Copy link

faily-bot bot commented Oct 27, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 34621: failure

mysql8.0-php7.4

Show full log
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Files\Storage\Wrapper\QuotaTest::testFreeSpaceWithUsedSpaceAndEncryption
Failed asserting that -1 matches expected 2.

/drone/src/tests/lib/Files/Storage/Wrapper/QuotaTest.php:100

acceptance-header

  • tests/acceptance/features/header.feature:44
Show full log
  Scenario: just added users are seen in the contacts menu               # /drone/src/tests/acceptance/features/header.feature:44
    Given I am logged in as the admin                                    # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the User settings                                         # SettingsMenuContext::iOpenTheUserSettings()
    And I click the New user button                                      # UsersSettingsContext::iClickTheNewUserButton()
      New user button in Users Settings could not be found (NoSuchElementException)
    And I see that the new user form is shown                            # UsersSettingsContext::iSeeThatTheNewUserFormIsShown()
    And I create user user1 with password 123456acb                      # UsersSettingsContext::iCreateUserWithPassword()
    And I see that the list of users contains the user user1             # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
    When I open the Contacts menu                                        # ContactsMenuContext::iOpenTheContactsMenu()
    Then I see that the Contacts menu is shown                           # ContactsMenuContext::iSeeThatTheContactsMenuIsShown()
    And I see that the contact "user0" in the Contacts menu is shown     # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsShown()
    And I see that the contact "user1" in the Contacts menu is shown     # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsShown()
    And I see that the contact "admin" in the Contacts menu is not shown # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsNotShown()

acceptance-users

  • tests/acceptance/features/users.feature:13
Show full log
  Scenario: create a new user with a custom display name               # /drone/src/tests/acceptance/features/users.feature:13
    Given I am logged in as the admin                                  # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the User settings                                       # SettingsMenuContext::iOpenTheUserSettings()
    When I click the New user button                                   # UsersSettingsContext::iClickTheNewUserButton()
      New user button in Users Settings could not be found (NoSuchElementException)
    And I see that the new user form is shown                          # UsersSettingsContext::iSeeThatTheNewUserFormIsShown()
    And I set the user name for the new user to "test"                 # UsersSettingsContext::iSetTheUserNameForTheNewUserTo()
    And I set the display name for the new user to "Test display name" # UsersSettingsContext::iSetTheDisplayNameForTheNewUserTo()
    And I set the password for the new user to "123456acb"             # UsersSettingsContext::iSetThePasswordForTheNewUserTo()
    And I create the new user                                          # UsersSettingsContext::iCreateTheNewUser()
    Then I see that the list of users contains the user "test"         # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()

@rullzer rullzer merged commit 7949854 into master Oct 27, 2020
@rullzer rullzer deleted the enh/noid/add-size-to-file-obj-definition branch October 27, 2020 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants