Properly put hidden-visually off-screen

[PVince81]

In some situations the element is still affecting the layout, especially
when a sticky is nearby.

This fix moves it properly off-screen.

There is a risk that this might break existing layouts that were relying on this, if any.

[skjnldsv]

Looks good, make sense :)

[PVince81]

Ref for the place it was discovered in the Talk app: nextcloud/spreed#4493 (comment)

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 34787: failure

mariadb10.4-php7.4

Show full log

There was 1 error:

1) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testMultiCalendarObjects
TypeError: Argument 2 passed to OCA\DAV\Events\CalendarCreatedEvent::__construct() must be of the type array, null given, called in /drone/src/apps/dav/lib/CalDAV/CalDavBackend.php on line 790

/drone/src/apps/dav/lib/Events/CalendarCreatedEvent.php:51
/drone/src/apps/dav/lib/CalDAV/CalDavBackend.php:790
/drone/src/apps/dav/tests/unit/CalDAV/AbstractCalDavBackend.php:153
/drone/src/apps/dav/tests/unit/CalDAV/CalDavBackendTest.php:314

--

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

mysql5.6-php7.3

Show full log

There was 1 error:

1) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testPurgeAllCachedEventsForSubscription
TypeError: Argument 2 passed to OCA\DAV\Events\SubscriptionCreatedEvent::__construct() must be of the type array, null given, called in /drone/src/apps/dav/lib/CalDAV/CalDavBackend.php on line 2117

/drone/src/apps/dav/lib/Events/SubscriptionCreatedEvent.php:51
/drone/src/apps/dav/lib/CalDAV/CalDavBackend.php:2117
/drone/src/apps/dav/tests/unit/CalDAV/AbstractCalDavBackend.php:173
/drone/src/apps/dav/tests/unit/CalDAV/CalDavBackendTest.php:963

--

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

[rullzer]

sure