fix: Move login via email logic to local backend #47686
Open
+137
−330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
feature: users and groups
technical debt
php
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
lib/private/User/Database.php
Outdated
| private function loadUser($uid) { | ||
| $this->fixDI(); | ||
| private function loadUser(string $loginName, bool $tryEmail = true): bool { | ||
| $uid = (string)$loginName; |
Check failure
Code scanning / Psalm
RedundantCast
lib/private/User/Database.php
Outdated
| if ($result) { | ||
| // Also add cache result for the email | ||
| $this->cache[$uid] = [ | ||
| ...$this->cache[$emailUId], |
Check failure
Code scanning / Psalm
InvalidOperand
susnux
force-pushed
the
fix/move-email-logic-local-user-backend
branch
3 times, most recently
from
1b08425 to
e7fc0bd
Compare
Backends can decide which names they accept for login, e.g. with user_ldap you can configure arbitrary login fields. This was a hacky approach to allow login via email, so instead this is now only handled by the local user backend. This also fixes some other related problems: Other logic relys on `backend::get()` which was not handling email, so e.g. password policy could not block users logged in via email if they use out-dated passwords. Similar for other integrations, as the user backend was not consistent with what is a login name and what not. Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/move-email-logic-local-user-backend
branch
from
e7fc0bd to
5536284
Compare
susnux
added
3. to review
susnux
requested review from
nickvergessen,
ChristophWurst,
come-nc and
blizzz
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Backends can decide which names they accept for login, e.g. with user_ldap you can configure arbitrary login fields. This was a hacky approach to allow login via email, so instead this is now only handled by the local user backend.
This also fixes some other related problems:
Other logic relys on
backend::get()which was not handling email, so e.g. password policy could not block users logged in via email if they use out-dated passwords.Similar for other integrations, as the user backend was not consistent with what is a login name and what not.
Checklist