fix(files_sharing): Respect permissions passed when creating link shares #50270
+342
−251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable30 |
come-nc
reviewed
Jan 20, 2025
Merged
susnux
commented
Jan 21, 2025
come-nc
reviewed
Jan 21, 2025
| : Constants::PERMISSION_READ; | ||
| } | ||
|
|
||
| // TODO: It might make sense to have a dedicated setting to allow/deny converting link shares into federated ones |
There was a problem hiding this comment.
Suggested change
| // TODO: It might make sense to have a dedicated setting to allow/deny converting link shares into federated ones |
This is a feature request and should not be in the code in my opinion.
There was a problem hiding this comment.
Its not from me but just moved, see in "delete" side of the GIT diff line 721.
susnux
force-pushed
the
fix/share-api-create--permissions
branch
from
aa86d75 to
ad555f6
Compare
Given: User creates a link or email share with permissions=4 (create only = file drop). Problem: Currently the permissions are automatically extended to permissions = 5 (READ + CREATE). Work around was to create the share and directly update it. Solution: Respect what the user is requesting, create a file drop share. Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/share-api-create--permissions
branch
from
ad555f6 to
2914318
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Given:
Problem:
Solution:
Checklist