Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added parameter to disable web UI integration with local client #50280

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pboguslawski
Copy link
Contributor

Summary

Added system config parameter web_ui_integration_local_client.enabled to allow disabling integration with local client from web UI (i.e. when local Nextcloud clients are not used).

Use

occ config:system:set web_ui_integration_local_client.enabled --value='true' --type=boolean

to enable (default if not set) and

occ config:system:set web_ui_integration_local_client.enabled --value='false' --type=boolean

to disable integration.

Use added parameter to show/hide Edit locally option in Nextcloud Files.

Related: https://help.nextcloud.com/t/how-remove-hide-edit-locally-option-in-web-interface/171999/5
Author-Change-Id: IB#1156402

Checklist

Added system config parameter `web_ui_integration_local_client.enabled`
to allow disabling integration with local client from web UI (i.e. when
local Nextcloud clients are not used).

Use
```
occ config:system:set web_ui_integration_local_client.enabled --value='true' --type=boolean
```
to enable (default if not set) and
```
occ config:system:set web_ui_integration_local_client.enabled --value='false' --type=boolean
```
to disable  integration.

Use added parameter to show/hide `Edit locally` option in Nextcloud Files.

Related: https://help.nextcloud.com/t/how-remove-hide-edit-locally-option-in-web-interface/171999/5
Author-Change-Id: IB#1156402
Signed-off-by: Pawel Boguslawski <[email protected]>
Fixes: f58ce7e
Author-Change-Id: IB#1156402
Signed-off-by: Pawel Boguslawski <[email protected]>
@solracsf
Copy link
Member

Wouldn't this make more sense in the... Web UI itself ?

@pboguslawski
Copy link
Contributor Author

Wouldn't this make more sense in the... Web UI itself ?

It's meant for admin to be able to disable such options globally using config file not per user.

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it’s still enabled by default (as it seems to be) and not too much of a maintenance load (@sorbaugh @skjnldsv) I’m fine with it.

@skjnldsv skjnldsv added the 3. to review Waiting for reviews label Jan 28, 2025
@skjnldsv skjnldsv added this to the Nextcloud 32 milestone Jan 28, 2025
@jancborchardt
Copy link
Member

Adding @juliusknorr as he mentioned we might already have a config for this in richdocuments, and should make sure both are 1 setting only. (But possibly using this server-wide setting.)

@juliusknorr
Copy link
Member

This makes sense for instances that do not make use of the desktop client at all. For that reason we have a setting in richdocuments, but having a global one seems more reasonable, we should adapt to respect that in richdocuments once this PR is merged (https://github.com/nextcloud/richdocuments/blob/920cf96886400abafffbc82ad414145408fd6d6d/lib/Service/InitialStateService.php#L112)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants