Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(settings): Fix setup check when mail_smptmode is set to "null" #50281

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Jan 20, 2025

Follow-up of #48977

Summary

Skip irrelevant setup check when mail_smtpmode is set to "null".

Checklist

@come-nc come-nc added the 3. to review Waiting for reviews label Jan 20, 2025
@come-nc come-nc added this to the Nextcloud 31 milestone Jan 20, 2025
@come-nc come-nc self-assigned this Jan 20, 2025
@solracsf
Copy link
Member

Does this need to be backported, since the PR intrducing this feature wasn't ?

@Altahrim Altahrim mentioned this pull request Jan 21, 2025
@come-nc
Copy link
Contributor Author

come-nc commented Jan 21, 2025

Does this need to be backported, since the PR intrducing this feature wasn't ?

No, you’re right, I misread the user feedback, I though the problem was on 30 but it’s on 31 RC.

@come-nc come-nc requested review from a team, artonge, nfebe and yemkareems and removed request for a team January 21, 2025 09:06
@Altahrim Altahrim mentioned this pull request Jan 23, 2025
@AndyScherzinger
Copy link
Member

/backport to stable31

@AndyScherzinger
Copy link
Member

Than it needs to be backported by now since the 31 branch off happened last week with RC1

@AndyScherzinger AndyScherzinger merged commit 4a7c0b3 into master Jan 30, 2025
189 checks passed
@AndyScherzinger AndyScherzinger deleted the fix/fix-email-setupcheck-with-null-smtpmode branch January 30, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants