Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make sure we process mime extensions as string #50660

Merged
merged 2 commits into from
Feb 6, 2025
Merged

fix: make sure we process mime extensions as string #50660

merged 2 commits into from
Feb 6, 2025

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Feb 5, 2025 •
edited
Loading

Fix #42902

  • Fix extension handling
  • Added phpunit tests

@skjnldsv skjnldsv added this to the Nextcloud 32 milestone Feb 5, 2025
@skjnldsv skjnldsv requested review from tcitworld, kesselb and a team February 5, 2025 10:52
@skjnldsv skjnldsv self-assigned this Feb 5, 2025
@skjnldsv skjnldsv requested review from icewind1991, Altahrim and come-nc and removed request for a team February 5, 2025 10:52
@skjnldsv skjnldsv mentioned this pull request Feb 5, 2025
Closed
8 tasks
@skjnldsv
Copy link
Member Author

skjnldsv commented Feb 5, 2025

/backport to stable31

@skjnldsv
Copy link
Member Author

skjnldsv commented Feb 5, 2025

/backport to stable30

@skjnldsv
Copy link
Member Author

skjnldsv commented Feb 5, 2025

/backport to stable29

AndyScherzinger
AndyScherzinger approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code-wise

tcitworld
tcitworld reviewed Feb 5, 2025
View reviewed changes
lib/public/Files/IMimeTypeDetector.php Outdated Show resolved Hide resolved
lib/private/Files/Type/Detection.php Outdated Show resolved Hide resolved
@skjnldsv skjnldsv requested a review from tcitworld February 5, 2025 11:35
kesselb
kesselb approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

susnux
susnux previously requested changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Return type of interface and implementation does not match

lib/public/Files/IMimeTypeDetector.php Outdated Show resolved Hide resolved
@skjnldsv @susnux
fix: psalm and OCP @SInCE declarations
1e30936 
Co-authored-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: John Molakvoæ <[email protected]>
@skjnldsv skjnldsv merged commit 93c72f5 into master Feb 6, 2025
182 of 189 checks passed
@skjnldsv skjnldsv deleted the fix/mime-int branch February 6, 2025 15:13
This was referenced Feb 6, 2025
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@kesselb kesselb kesselb approved these changes

@susnux susnux susnux left review comments

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 was automatically assigned from nextcloud/server-backend

@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim was automatically assigned from nextcloud/server-backend

@come-nc come-nc Awaiting requested review from come-nc come-nc was automatically assigned from nextcloud/server-backend

@tcitworld tcitworld Awaiting requested review from tcitworld

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug feature: files
Projects
None yet
Milestone
Nextcloud 32
Development

Successfully merging this pull request may close these issues.

[Bug]: Unable to set .0 through .9 as mimetypemapping.json
5 participants
@skjnldsv @AndyScherzinger @susnux @tcitworld @kesselb