Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): Do not download files with openfile query flag #50669

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Feb 5, 2025

Summary

If openfile is set on a folder or file that cannot be opened (there is no app for it) we should not download it.
Instead we should show the sidebar (opendetails) and let the user decide to download it.

Checklist

@susnux susnux added this to the Nextcloud 32 milestone Feb 5, 2025
@susnux susnux requested review from marcoambrosini and a team February 5, 2025 17:34
@susnux susnux requested a review from skjnldsv as a code owner February 5, 2025 17:34
@susnux susnux requested review from artonge and sorbaugh and removed request for a team February 5, 2025 17:34
@susnux
Copy link
Contributor Author

susnux commented Feb 5, 2025

/backport to stable31

@susnux
Copy link
Contributor Author

susnux commented Feb 5, 2025

/backport to stable30

Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 👍

@susnux susnux force-pushed the fix/files-show-details-when-no-action branch 2 times, most recently from ec4a79f to 6b0f942 Compare February 5, 2025 23:21
Instead of downloading files, if there is no other default action,
we should just open the details tab.

Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux force-pushed the fix/files-show-details-when-no-action branch from 0e96fb6 to fcdfb9e Compare February 6, 2025 01:17
@susnux susnux merged commit c79ad18 into master Feb 6, 2025
120 checks passed
@susnux susnux deleted the fix/files-show-details-when-no-action branch February 6, 2025 01:28
Copy link

backportbot bot commented Feb 6, 2025

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/50669/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick dbc5c10b fcdfb9ef

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/50669/stable30

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@susnux
Copy link
Contributor Author

susnux commented Feb 6, 2025

/backport to stable30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop immediate download of files when opening them from talk or deck ("in Dateien anzeigen")
3 participants