fix(AccountProperty): better validation of twitter and fediverse handles #50678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
bug
3. to review
|
/backport to stable31 |
|
/backport to stable30 |
|
/backport to stable29 |
susnux
force-pushed
the
fix/harden-account-properties
branch
from
2227cff to
d8e3ba8
Compare
Pytal
approved these changes
Feb 5, 2025
| } | ||
|
|
||
| try { | ||
| return URL.parse(`https://${result[2]}/`) !== null |
There was a problem hiding this comment.
Nice, only knew of the new URL way before 💯
susnux
force-pushed
the
fix/harden-account-properties
branch
from
d8e3ba8 to
6675740
Compare
AndyScherzinger
approved these changes
Feb 6, 2025
skjnldsv
approved these changes
Feb 6, 2025
susnux
force-pushed
the
fix/harden-account-properties
branch
from
96573e1 to
d7c0626
Compare
Ensure to only accept valid X and fediverse handles. Signed-off-by: Ferdinand Thiessen <[email protected]>
Harden also for existing values of the profile. Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
…tend Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/harden-account-properties
branch
from
d7c0626 to
241545b
Compare
This was referenced Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make sure that twitter and fediverse handles are in a valid format.
Checklist