Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(object_store): Add support for session token (STS) in AWS credentials #50702

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

refucktor
Copy link

@refucktor refucktor commented Feb 6, 2025

Summary

Support using a Session Token for temporal AWS Credentials

Checklist

- Pass session token, either null or with value, to the AWS Credentials constructor

Signed-off-by: Hector Valcarcel <[email protected]>
@refucktor refucktor force-pushed the feat/support-aws-session-token branch from fcea40d to 6b4c859 Compare February 6, 2025 15:24
@joshtrichards joshtrichards added enhancement feature: object storage 3. to review Waiting for reviews pending documentation This pull request needs an associated documentation update labels Feb 6, 2025
@joshtrichards
Copy link
Member

I wonder what it'd take to add an integration test for this... 🤔

https://min.io/docs/minio/linux/developers/security-token-service.html
https://github.com/minio/minio/tree/master/docs/sts

@joshtrichards joshtrichards changed the title Add support for session token in AWS credentials feat(object_store): Add support for session token (STS) in AWS credentials Feb 6, 2025
@joshtrichards
Copy link
Member

How does the expiration/rotation of STS credentials work here given that the Nextcloud use case for S3 is ongoing not temporary?

@refucktor
Copy link
Author

@joshtrichards that could be an interesting step. However, I would recommend trying a different direction for the integration tests, something like a combination of:

then you can manage all the outside platforms directly via code 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement feature: object storage pending documentation This pull request needs an associated documentation update
Projects
None yet
2 participants