[stable30] fix(dav): allow uploading of files with long filenames #52377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce nesting and drop duplicated sections. Signed-off-by: Ferdinand Thiessen <[email protected]>
A filename must be less or equal 255 characters, but when adding the `.part` and `.ocfiletransfer` extensions we might overflow this limit. So we should also use filename hashes for uploading when the file has a long filename, similar like when we are uploading to the user storage directly. Signed-off-by: Ferdinand Thiessen <[email protected]>
backportbot
bot
requested review from
come-nc,
provokateurin,
skjnldsv and
susnux
backportbot
bot
added
bug
3. to review
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| $this->l10n->t( | ||
| 'Error while copying file to target location (copied: %1$s, expected filesize: %2$s)', | ||
| [ | ||
| $this->l10n->n('%n byte', '%n bytes', $count), |
Check notice
Code scanning / Psalm
PossiblyUndefinedVariable Note
| ); | ||
| } | ||
| if ($expected >= 0 | ||
| && $expected !== $count |
Check notice
Code scanning / Psalm
PossiblyUndefinedVariable Note
| 'Expected filesize of %1$s but read (from Nextcloud client) and wrote (to Nextcloud storage) %2$s. Could either be a network problem on the sending side or a problem writing to the storage on the server side.', | ||
| [ | ||
| $this->l10n->n('%n byte', '%n bytes', $expected), | ||
| $this->l10n->n('%n byte', '%n bytes', $count), |
Check notice
Code scanning / Psalm
PossiblyUndefinedVariable Note
provokateurin
approved these changes
Apr 23, 2025
susnux
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #51491