Skip to content

feat: add IUserFolder similar to IRootFolder #53048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
susnux wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

feat: add IUserFolder similar to IRootFolder #53048

susnux wants to merge 7 commits into from

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented May 22, 2025 •
edited by come-nc
Loading

Summary

TBD

Checklist

@susnux susnux added this to the Nextcloud 32 milestone May 22, 2025
@susnux susnux added enhancement 3. to review Waiting for reviews labels May 22, 2025
@susnux susnux force-pushed the feat/user-folder branch from f31e363 to 2013bba Compare May 22, 2025 13:47
come-nc
come-nc reviewed Jun 26, 2025
View reviewed changes
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
@come-nc come-nc self-assigned this Dec 16, 2025
@come-nc
Copy link
Contributor

come-nc commented Dec 16, 2025

I do not understand these last 4 errors and how to get rid of them 😿

There were 4 errors:
1) OCA\Files_Sharing\Tests\ApiTest::testGetShareFromSourceWithReshares
OCP\Files\NotPermittedException: Could not create folder "/test-share-user2", folder exists but unable to get cache entry
/home/runner/actions-runner/_work/server/server/lib/private/Files/Node/Folder.php:143
/home/runner/actions-runner/_work/server/server/lib/private/Files/Node/Folder.php:501
/home/runner/actions-runner/_work/server/server/lib/private/Files/Node/LazyUserFolder.php:50
/home/runner/actions-runner/_work/server/server/lib/private/Files/Node/LazyFolder.php:51
/home/runner/actions-runner/_work/server/server/lib/private/Files/Node/LazyFolder.php:65
/home/runner/actions-runner/_work/server/server/lib/private/Files/Node/LazyFolder.php:206
/home/runner/actions-runner/_work/server/server/lib/private/Share20/Manager.php:210
/home/runner/actions-runner/_work/server/server/lib/private/Share20/Manager.php:639
/home/runner/actions-runner/_work/server/server/apps/files_sharing/tests/ApiTest.php:523
2) OCA\Files_Sharing\Tests\ApiTest::testGetShareFromFolderReshares
OCP\Files\NotPermittedException: Could not create folder "/test-share-user2", folder exists but unable to get cache entry
/home/runner/actions-runner/_work/server/server/lib/private/Files/Node/Folder.php:143
/home/runner/actions-runner/_work/server/server/lib/private/Files/Node/Folder.php:501
/home/runner/actions-runner/_work/server/server/lib/private/Files/Node/LazyUserFolder.php:50
/home/runner/actions-runner/_work/server/server/lib/private/Files/Node/LazyFolder.php:51
/home/runner/actions-runner/_work/server/server/lib/private/Files/Node/LazyFolder.php:65
/home/runner/actions-runner/_work/server/server/lib/private/Files/Node/LazyFolder.php:206
/home/runner/actions-runner/_work/server/server/lib/private/Share20/Manager.php:210
/home/runner/actions-runner/_work/server/server/lib/private/Share20/Manager.php:639
/home/runner/actions-runner/_work/server/server/apps/files_sharing/tests/ApiTest.php:638
3) OCA\Files_Sharing\Tests\ApiTest::testGetShareMultipleSharedFolder
OCP\Files\NotPermittedException: Could not create folder "/test-share-user2", folder exists but unable to get cache entry
/home/runner/actions-runner/_work/server/server/lib/private/Files/Node/Folder.php:[143](https://github.com/nextcloud/server/actions/runs/20283089930/job/58250083307?pr=53048#step:8:144)
/home/runner/actions-runner/_work/server/server/lib/private/Files/Node/Folder.php:501
/home/runner/actions-runner/_work/server/server/lib/private/Files/Node/LazyUserFolder.php:50
/home/runner/actions-runner/_work/server/server/lib/private/Files/Node/LazyFolder.php:51
/home/runner/actions-runner/_work/server/server/lib/private/Files/Node/LazyFolder.php:65
/home/runner/actions-runner/_work/server/server/lib/private/Files/Node/LazyFolder.php:206
/home/runner/actions-runner/_work/server/server/lib/private/Share20/Manager.php:210
/home/runner/actions-runner/_work/server/server/lib/private/Share20/Manager.php:639
/home/runner/actions-runner/_work/server/server/apps/files_sharing/tests/ApiTest.php:825
4) OCA\Files_Sharing\Tests\EtagPropagationTest::testOwnerUnshares
OCP\Files\NotPermittedException: Could not create folder "/test-share-user2", folder exists but unable to get cache entry
/home/runner/actions-runner/_work/server/server/lib/private/Files/Node/Folder.php:143
/home/runner/actions-runner/_work/server/server/lib/private/Files/Node/Folder.php:501
/home/runner/actions-runner/_work/server/server/lib/private/Files/Node/LazyUserFolder.php:50
/home/runner/actions-runner/_work/server/server/lib/private/Files/Node/LazyFolder.php:51
/home/runner/actions-runner/_work/server/server/lib/private/Files/Node/LazyFolder.php:65
/home/runner/actions-runner/_work/server/server/lib/private/Files/Node/LazyFolder.php:206
/home/runner/actions-runner/_work/server/server/lib/private/Share20/Manager.php:210
/home/runner/actions-runner/_work/server/server/lib/private/Share20/Manager.php:1107
/home/runner/actions-runner/_work/server/server/lib/private/Share20/Manager.php:1[147](https://github.com/nextcloud/server/actions/runs/20283089930/job/58250083307?pr=53048#step:8:148)
/home/runner/actions-runner/_work/server/server/apps/files_sharing/tests/EtagPropagationTest.php:275

susnux and others added 7 commits December 16, 2025 23:55
@susnux @come-nc
feat(IUserFolder): add a user folder class
bfdac86 
* Implements #52896

Similar to the root folder this represents the users home folder,
it allows to group user based methods on the folder like the user quota.

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux @come-nc
chore: migrate away from deprecated OC_Helper to IUserFolder
13f1caf 
Signed-off-by: Ferdinand Thiessen <[email protected]>
@come-nc
fix: Use new getOrCreate method and fix code issues
5270684 
Signed-off-by: Côme Chilliet <[email protected]>
@come-nc
fix: Adapt LazyRoot::getUserFolder signature and remove LazyFolder::g…
a7a089e 
…etUserFolder

Signed-off-by: Côme Chilliet <[email protected]>
@come-nc
chore: Adapt tests to getUserFolder return type change
f355c8d 
Signed-off-by: Côme Chilliet <[email protected]>
@come-nc
fix: fix more tests
abfc5c5 
Signed-off-by: Côme Chilliet <[email protected]>
@come-nc
chore: Fix psalm issues and update baseline
ec59b84 
Signed-off-by: Côme Chilliet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@come-nc come-nc come-nc left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

@susnux susnux

@come-nc come-nc

Labels

3. to review Waiting for reviews enhancement

Projects

None yet

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

Move getStorageInfo to non-legacy code

4 participants

@susnux @come-nc @skjnldsv