Skip to content

feat(RequestHeader): Add indirect parameter #53283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
provokateurin merged 3 commits into from
Jun 3, 2025
Merged

feat(RequestHeader): Add indirect parameter #53283

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
18e04e1
chore(RequestHeader): Remove unnecessary getters
provokateurin Jun 3, 2025
727b0c8
refactor(RequestHeader): Make parameter types stricter
provokateurin Jun 3, 2025
c3aa531
feat(RequestHeader): Add indirect parameter
provokateurin Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 4 additions & 20 deletions lib/public/AppFramework/Http/Attribute/RequestHeader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,30 +21,14 @@
#[Attribute(Attribute::TARGET_METHOD | Attribute::IS_REPEATABLE)]
class RequestHeader {
/**
* @param string $name The name of the request header
* @param string $description The description of the request header
* @param lowercase-string $name The name of the request header
* @param non-empty-string $description The description of the request header
* @param bool $indirect Allow indirect usage of the header for example in a middleware. Enabling this turns off the check which ensures that the header must be referenced in the controller method.
*/
public function __construct(
protected string $name,
protected string $description,
protected bool $indirect = false,
) {
}

/**
* @return string The name of the request header.
*
* @since 32.0.0
*/
public function getName(): string {
return $this->name;
}

/**
* @return string The description of the request header.
*
* @since 32.0.0
*/
public function getDescription(): string {
return $this->description;
}
}
Loading