-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
[stable30] fix(files_sharing): Implement conditional federation placeholder #54368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfebe
approved these changes
Aug 11, 2025
Contributor
|
/compile |
skjnldsv
approved these changes
Aug 11, 2025
skjnldsv
previously requested changes
Aug 11, 2025
Member
skjnldsv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing the appManager contruct init
cfbb93d to
793a039
Compare
793a039 to
156590d
Compare
156590d to
41d656c
Compare
41d656c to
4c77f71
Compare
This commits addresses an annoyance where the share input placeholder would suggest sharing via federated cloud ID even if federation was disabled. Signed-off-by: nfebe <[email protected]>
4c77f71 to
8ec8378
Compare
Member
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
AndyScherzinger
approved these changes
Aug 27, 2025
Member
AndyScherzinger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐘
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #54310
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.