Skip to content

Improve connectivity check #55321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
come-nc merged 2 commits into from
Sep 28, 2025
Merged

Improve connectivity check #55321

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc3851f
fix(setupchecks): Use a lighter request to test connectivity
come-nc Sep 26, 2025
1c4276e
fix(setupchecks): Remove startpage from connectivity check and avoid …
come-nc Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/settings/lib/SetupChecks/InternetConnectivity.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public function run(): SetupResult {
}

$siteArray = $this->config->getSystemValue('connectivity_check_domains', [
'https://www.nextcloud.com', 'https://www.startpage.com', 'https://www.eff.org', 'https://www.edri.org'
'https://connectivity.nextcloud.com', 'https://www.eff.org', 'https://edri.org'
]);

foreach ($siteArray as $site) {
Copy link
Member

@joshtrichards joshtrichards Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
foreach ($siteArray as $site) {
shuffle($siteArray);
foreach ($siteArray as $site) {

Copy link
Contributor Author

@come-nc come-nc Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we prefer to default to the same one always and avoid random behavior.

Expand All @@ -67,7 +67,7 @@ private function isSiteReachable(string $site): bool {
}
try {
$client = $this->clientService->newClient();
$client->get($site);
$client->head($site);
} catch (\Exception $e) {
$this->logger->error('Cannot connect to: ' . $site, [
'app' => 'internet_connection_check',
Expand Down
Loading