-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Implement manual prefix setting for configuration ldap #55424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This is my first PR on the repo server, so please feel free to give feedback. |
come-nc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use the returned prefix in your script instead?
When using occ ldap:create-empty-config --only-print-prefix, the only output is the prefix and you can then store that in a variable in your script.
There are two reasons related to the operation of AIO community containers:
For these reasons, it would be useful to have an identifier known in advance. |
Add option to manually set configuration prefix with validation. Signed-off-by: Jean-Yves <[email protected]>
Signed-off-by: Jean-Yves <[email protected]>
|
Adding this feature could lead to inappropriate behaviour if a user creates an Maybe prefixes should be generated in a way that makes them unique (e.g. uuid). |
Currently you cannot afaik but I guess we could add support for it... |
That shouldn't solve the update problem. |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
For this reason and other potential pitfalls I prefer to stay away from manually set prefix, LDAP configuration prefixes should stay automated. |
Summary
This allows you to manually define an LDAP configuration prefix. This is useful for scripts.
The scripts know the prefix and can manage their configuration without interacting with other configurations.
Checklist
3. to review, feature component)stable32)