Skip to content

fix(ldap): Fix copying and creating LDAP configuration #55576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
come-nc merged 1 commit into from
Oct 6, 2025
Merged

fix(ldap): Fix copying and creating LDAP configuration #55576

come-nc merged 1 commit into from
Oct 6, 2025

Conversation

@come-nc
Copy link
Contributor

@come-nc come-nc commented Oct 6, 2025

Summary

array_pop was used instead of end, as a result the new prefix list did not contain the previous one, and new configuration prefixes were replacing instead of being added to the list of prefixes.

Checklist

@come-nc come-nc added this to the Nextcloud 33 milestone Oct 6, 2025
@come-nc come-nc self-assigned this Oct 6, 2025
@come-nc come-nc requested a review from a team as a code owner October 6, 2025 13:49
@come-nc come-nc added the 3. to review Waiting for reviews label Oct 6, 2025
@come-nc come-nc requested review from icewind1991 and removed request for a team October 6, 2025 13:49
@come-nc come-nc requested review from nfebe and salmart-dev October 6, 2025 13:49
@come-nc
Copy link
Contributor Author

come-nc commented Oct 6, 2025

/backport to stable32

susnux
susnux reviewed Oct 6, 2025
View reviewed changes
AndyScherzinger
AndyScherzinger approved these changes Oct 6, 2025
View reviewed changes
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@come-nc come-nc enabled auto-merge October 6, 2025 16:03
@come-nc come-nc added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 6, 2025
@come-nc come-nc mentioned this pull request Oct 6, 2025
Merged
7 tasks
@come-nc come-nc merged commit 818f54d into master Oct 6, 2025
217 of 226 checks passed
@come-nc come-nc deleted the fix/ldap-configuration-prefix-list branch October 6, 2025 16:22
@backportbot backportbot bot mentioned this pull request Oct 6, 2025
Merged
@nextcloud-bot nextcloud-bot mentioned this pull request Jan 6, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@provokateurin provokateurin provokateurin approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend

@salmart-dev salmart-dev Awaiting requested review from salmart-dev salmart-dev is a code owner automatically assigned from nextcloud/server-backend

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-backend

@blizzz blizzz Awaiting requested review from blizzz

@artonge artonge Awaiting requested review from artonge

Assignees

@come-nc come-nc

Labels

4. to release Ready to be released and/or waiting for tests to finish feature: ldap

Projects

None yet

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

6 participants

@come-nc @AndyScherzinger @susnux @CarlSchwan @provokateurin