-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
chore: remove OC.fileIsBlacklisted
#56088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaimen
approved these changes
Oct 30, 2025
Contributor
szaimen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐘
artonge
approved these changes
Oct 30, 2025
8f6ea6a to
4255cee
Compare
Contributor
Author
|
/compile |
Contributor
Author
|
Documentation: nextcloud/documentation#13828 |
d4e6881 to
6cc81ff
Compare
Contributor
Author
|
/compile amend |
6cc81ff to
bb8db46
Compare
Its deprecated since Nextcloud 18 and nowadays we have much more complex logic for this. So the proper replacement is to use `validateFilename` from `@nextcloud/files` package. Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
bb8db46 to
f52e838
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3. to review
Waiting for reviews
♻️ refactor
Refactor code (not a bug fix, not a feature just refactoring)
technical debt
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Its deprecated since Nextcloud 18 and nowadays we have much more complex logic for this.
So the proper replacement is to use
validateFilenamefrom@nextcloud/filespackage.Checklist
3. to review, feature component)stable32)