fix(View): Normalize path in getAbsolutePath #56223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
force-pushed
the
artonge/fix/remove_unecessary_condition
branch
from
3708dff to
11f8306
Compare
artonge
added
bug
3. to review
artonge
requested review from
Altahrim,
CarlSchwan,
icewind1991 and
yemkareems
and removed request for
a team
artonge
force-pushed
the
artonge/fix/remove_unecessary_condition
branch
from
0c91361 to
e4bb0ba
Compare
artonge
added
2. developing
artonge
force-pushed
the
artonge/fix/remove_unecessary_condition
branch
from
e4bb0ba to
120544e
Compare
artonge
changed the title
NodeDeletedEvent
artonge
force-pushed
the
artonge/fix/remove_unecessary_condition
branch
from
120544e to
0909f4d
Compare
artonge
added
3. to review
come-nc
approved these changes
Nov 24, 2025
icewind1991
approved these changes
Nov 25, 2025
Member
icewind1991
left a comment
icewind1991
left a comment
There was a problem hiding this comment.
I think the behavior change should be fine
icewind1991
reviewed
Nov 25, 2025
artonge
force-pushed
the
artonge/fix/remove_unecessary_condition
branch
from
0909f4d to
8729c62
Compare
…by a try/catch Deleted nodes are always non existing, but some of them have a fileInfo. This ensure that we still run the cleanup but in a safe way. Signed-off-by: Louis Chmn <[email protected]>
This allow to match files more consistently in HookConnector::getNodeForPath Signed-off-by: Louis Chmn <[email protected]>
artonge
force-pushed
the
artonge/fix/remove_unecessary_condition
branch
from
8729c62 to
73c6b17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially was only to remove what seems to be an unnecessary check in
NodeDeletedEvent, but CI highlighted some issue with path management.Previously, the method was happily returning path with trailing
/, this is not the case now. I am a bit afraid of side effects.Fix #53667