Skip to content

Conversation

@ArtificialOwl
Copy link
Member

@ArtificialOwl ArtificialOwl commented Nov 6, 2025

if set as local system address book, a userId is expected in some place like

if (isset($contact['isLocalSystemBook'])) {
if ($this->shareWithGroupOnly) {
/*
* Check if the user may share with the user associated with the e-mail of the just found contact
*/
$userGroups = $this->groupManager->getUserGroupIds($this->userSession->getUser());
// ShareWithGroupOnly filtering
$userGroups = array_diff($userGroups, $this->shareWithGroupOnlyExcludeGroupsList);
$found = false;
foreach ($userGroups as $userGroup) {
if ($this->groupManager->isInGroup($contact['UID'], $userGroup)) {
$found = true;
break;
}
}
if (!$found) {
continue;
}
}

This fix allow app like ldap_contacts_backend to using a new configuration key to set itself as a local non-system address book

nextcloud/ldap_contacts_backend#350

@blizzz
Copy link
Member

blizzz commented Nov 11, 2025

could we find a positive name, that describes what it is? isVirtualAdressbook or something like this?

@ArtificialOwl ArtificialOwl force-pushed the fix/noid/set-adr-book-local-but-not-system branch from 3fe5a94 to bd6fb93 Compare November 12, 2025 11:32
@ArtificialOwl
Copy link
Member Author

could we find a positive name, that describes what it is? isVirtualAdressbook or something like this?

totally agree; fun fact, I had the exact same name in mind but forgot to force push :D

@ArtificialOwl ArtificialOwl marked this pull request as ready for review November 12, 2025 11:45
@ArtificialOwl ArtificialOwl requested a review from a team as a code owner November 12, 2025 11:45
@ArtificialOwl ArtificialOwl requested review from CarlSchwan, icewind1991 and salmart-dev and removed request for a team November 12, 2025 11:45
@ArtificialOwl ArtificialOwl force-pushed the fix/noid/set-adr-book-local-but-not-system branch from bd6fb93 to 6edf519 Compare November 19, 2025 14:44
@ArtificialOwl ArtificialOwl force-pushed the fix/noid/set-adr-book-local-but-not-system branch from 6edf519 to b2a3448 Compare November 19, 2025 14:45
@ArtificialOwl ArtificialOwl force-pushed the fix/noid/set-adr-book-local-but-not-system branch 2 times, most recently from 10824a4 to 8202cd9 Compare December 22, 2025 12:58
@ArtificialOwl ArtificialOwl force-pushed the fix/noid/set-adr-book-local-but-not-system branch from 8202cd9 to b281764 Compare December 22, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants