-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
fix(settings): detect Chrome on Android correctly in device list #56450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix(settings): detect Chrome on Android correctly in device list #56450
Conversation
43d1282 to
b2554af
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
f8cf84b to
b89fc0f
Compare
b89fc0f to
bae24eb
Compare
|
@FaizanKamal7 you don't need to update this branch unless there are conflicts. Also please rebase onto the master branch instead of merging it into this branch. |
3de1e97 to
20f708f
Compare
Noted @provokateurin. I will rebase it instead of updating this branch |
Signed-off-by: Faizan Kamal <[email protected]>
20f708f to
ed6a5f5
Compare
Summary
Fixes #50502
Modern Chrome on Android no longer includes the "Build/" string in its user-agent, causing it to be incorrectly identified as "Chrome (Linux)" instead of "Chrome (Android)" in the device list at
/settings/user/security.Problem
The current
androidChromeregex pattern requires aBuild/string:However, as of 2021, Chrome on Android has reduced its user-agent string and no longer includes the device model and build information.
Current user-agent format:
Solution
Updated the
androidChromeregex pattern to:This pattern:
Testing
Manual Regex Verification
Tested the new pattern using JavaScript console against the user-agent string reported in #50502:
Results:
Test Results Summary
References
Checklist