fix(files_external): Fix registration of listeners with PHP >= 8.4 #56561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
come-nc
requested review from
Altahrim,
CarlSchwan,
leftybournes and
salmart-dev
and removed request for
a team
CarlSchwan
approved these changes
Nov 20, 2025
With the lazy ghosts the constructor is not always called in files_external boot. This is a quick and dirty fix but we should instead move the code out of the constructors and to the boot method. Signed-off-by: Côme Chilliet <[email protected]>
…thod This is the clean solution, LoginCredentials was the only auth class actually registering stuff in constructor. Signed-off-by: Côme Chilliet <[email protected]>
come-nc
force-pushed
the
fix/fix-files-external-with-php-84
branch
from
dcb7819 to
69b85fa
Compare
come-nc
added
3. to review
leftybournes
approved these changes
Nov 25, 2025
come-nc
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With the lazy ghosts the constructor is not always called in files_external boot.
Instead I moved the code out of the constructors and to the boot method.
Checklist
3. to review, feature component)stable32)