-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
chore: update @nextcloud/eslint-config to v9.0.0-rc.6 and fix issues
#56660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
szaimen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐘
| :model-value="value" | ||
| @input="onInput" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably should also check the events in the plugin.
| <template> | ||
| <fieldset class="permissions-select"> | ||
| <NcCheckboxRadioSwitch :checked="canCreate" @update:checked="toggle(PERMISSION_CREATE)"> | ||
| <NcCheckboxRadioSwitch :model-value="canCreate" @update:checked="toggle(PERMISSION_CREATE)"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting modelValue but handling update:checked feels incorrect even it works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW we still do not support @update:model-value this is never emitted. Only @update:modelValue is for Vue 2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting modelValue but handling update:checked feels incorrect even it works
(Rebased and additionally) added a new commit manually adjusting those events.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was pretty sure that it did not work when I was testing it, but now I cannot reproduce 🤔
19ac884 to
6bcc00d
Compare
|
/compile |
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
…Value`) Signed-off-by: Ferdinand Thiessen <[email protected]>
6bcc00d to
f1d2833
Compare
Signed-off-by: nextcloud-command <[email protected]>
|
Since this PR I get errors like those when opening the basic settings @susnux :
|
I cannot see any changed for But where did you see this messages? I looked through all settings and could not find this. |

Checklist
3. to review, feature component)stable32)