Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Nov 25, 2025

Summary

During the initial Vue 3 migration some dependencies were forgotten to be explicitly mentioned as dependencies.
This aligns those dependencies with the package.json It was only working because they were peer dependencies of other dependencies we already added.

Checklist

@susnux susnux added this to the Nextcloud 33 milestone Nov 25, 2025
@susnux susnux requested review from a team as code owners November 25, 2025 23:33
@susnux susnux requested review from skjnldsv and szaimen and removed request for a team November 25, 2025 23:33
@susnux susnux added the 3. to review Waiting for reviews label Nov 25, 2025
@susnux susnux requested a review from sorbaugh November 25, 2025 23:33
@susnux susnux requested a review from skjnldsv November 26, 2025 08:29
During the initial Vue 3 migration some dependencies were forgotten to
be explicitly mentioned as dependencies.
This aligns those dependencies with the package.json
It was only working because they were peer dependencies of other
dependencies we already added.

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux force-pushed the chore/deps-missing branch from 56db6d5 to 9baac21 Compare November 26, 2025 09:51
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux merged commit b279924 into master Nov 26, 2025
124 checks passed
@susnux susnux deleted the chore/deps-missing branch November 26, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants