fix(logger): add back lost params for logger methods #56716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miaulalala
requested review from
come-nc,
leftybournes,
salmart-dev and
yemkareems
and removed request for
a team
Contributor
Author
|
/backport to stable32 |
miaulalala
force-pushed
the
fix/logger
branch
3 times, most recently
from
77af2e5 to
9e473e3
Compare
nickvergessen
approved these changes
Nov 27, 2025
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
Is this testable so it does not get easily dropped again?
Signed-off-by: Anna Larch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally added in
#44761
#47293
Lost in #45094
Checklist
3. to review, feature component)stable32)