Skip to content

Conversation

@artonge
Copy link
Contributor

@artonge artonge commented Nov 27, 2025

Multiple fixes to improve deleting a config and configuring a new one:

  • Improve case where selected config is undefined
  • Disable some buttons when clicking them would lead to an issue
  • Properly update local variable for username and password in server settings
  • Properly use fall back message in case of empty response
  • Properly handle new config creation in settings

Fix #56070

@artonge artonge requested a review from a team as a code owner November 27, 2025 10:26
@artonge artonge requested review from nfebe, skjnldsv and susnux and removed request for a team November 27, 2025 10:26
@artonge artonge self-assigned this Nov 27, 2025
@artonge artonge added this to the Nextcloud 33 milestone Nov 27, 2025
@artonge
Copy link
Contributor Author

artonge commented Nov 27, 2025

EDIT: Found the issue, fixed in faaf850

@come-nc one weird irritating thing: when I create a new config, it is disabled by default, which is not bad. But when I test the config, while still disabled, the binding fails here:

if (!$connection->bind()) {
return new DataResponse([
'success' => false,
'message' => $this->l->t('Valid configuration, but binding failed. Please check the server settings and credentials.'),
]);
}

However, if I activate the config, it works. If I disable the config again, it works too. I tried debugging, but couldn't find any differences in the tested config before or after activating it.

Any idea?

@artonge artonge requested a review from a team as a code owner November 27, 2025 11:04
@artonge artonge requested review from leftybournes, salmart-dev and yemkareems and removed request for a team November 27, 2025 11:04
@artonge artonge added the php Pull requests that update Php code label Nov 27, 2025
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise it looks good

@artonge artonge force-pushed the artonge/fix/user_ldap/deleting_and_initial_config branch from faaf850 to e536449 Compare November 27, 2025 13:28
@artonge artonge requested review from blizzz, come-nc and susnux and removed request for leftybournes, nfebe, salmart-dev, skjnldsv, susnux and yemkareems December 2, 2025 11:05
@artonge artonge requested a review from skjnldsv December 2, 2025 11:05
@artonge artonge requested a review from come-nc December 3, 2025 15:35
@artonge
Copy link
Contributor Author

artonge commented Dec 4, 2025

/compile rebase /

@nextcloud-command nextcloud-command force-pushed the artonge/fix/user_ldap/deleting_and_initial_config branch from e536449 to 5e5ed7d Compare December 4, 2025 17:19
@artonge artonge enabled auto-merge December 5, 2025 08:45
@artonge artonge merged commit 8ec73e1 into master Dec 5, 2025
236 of 250 checks passed
@artonge artonge deleted the artonge/fix/user_ldap/deleting_and_initial_config branch December 5, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug feature: ldap javascript php Pull requests that update Php code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delete configuration in LDAP does not reset form fields (upcoming 33 only)

5 participants