[stable31] fix(sharing): Allow public share access for everyone #56797
+118
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfebe
approved these changes
Dec 2, 2025
nfebe
force-pushed
the
backport/55811/stable31
branch
from
c4dadbd to
569b46f
Compare
Member
|
Failure is related. |
When a logged-in user accesses a public share link in the same browser, the system was incorrectly checking if that user's groups were excluded from creating link shares. This caused share not found errors for users in excluded groups, even though public shares should be accessible to anyone with the link. The group exclusion setting (`shareapi_allow_links_exclude_groups`) is intended to restrict share creation, not share access. Public shares are meant to be anonymous and accessible regardless of the viewer identity or group membership. We now check the exclusion for the share creator and not the viewer. Signed-off-by: nfebe <[email protected]>
AndyScherzinger
force-pushed
the
backport/55811/stable31
branch
from
569b46f to
fb6a8ab
Compare
solracsf
reviewed
Dec 4, 2025
|
|
||
| $share = $this->manager->newShare(); | ||
| $share->setShareType(IShare::TYPE_LINK) | ||
| ->setPermissions(Constants::PERMISSION_READ); |
Member
There was a problem hiding this comment.
Suggested change
| ->setPermissions(Constants::PERMISSION_READ); | |
| ->setPermissions(\OCP\Constants::PERMISSION_READ); |
|
|
||
| $share = $this->manager->newShare(); | ||
| $share->setShareType(IShare::TYPE_LINK) | ||
| ->setPermissions(Constants::PERMISSION_READ); |
Member
There was a problem hiding this comment.
Suggested change
| ->setPermissions(Constants::PERMISSION_READ); | |
| ->setPermissions(\OCP\Constants::PERMISSION_READ); |
This was referenced Dec 4, 2025
provokateurin
requested changes
Dec 8, 2025
Member
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
Blocking until tests are fixed
This was referenced Dec 8, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #55811