refactor: drop need for an obscure (and legacy) OC_Util method... runningOnMac() ;-)
#56816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Easy enough query directly these days; Only used in one spot anyhow - Updated the runningOnMac method to use PHP_OS_FAMILY just for clarity until we can remove the function entirely (same result; supported since PHP ~7.4). Signed-off-by: Josh <[email protected]>
Use PHP's newer PHP_OS_FAMILY constant. - Allows us to drop a legacy OC_Util method. - This test isn't even enabled at the moment. Signed-off-by: Josh <[email protected]>
PHP_OS_FAMILY - Facilitates elimination of a legacy OC_Util method - `runningOnMac()` -- yes, really! ;-) - Supported since PHP late 7.x-era Signed-off-by: Josh <[email protected]>
joshtrichards
added
3. to review
joshtrichards
requested review from
ArtificialOwl,
leftybournes and
yemkareems
and removed request for
a team
joshtrichards
added
the
♻️ refactor
Signed-off-by: Carl Schwan <[email protected]>
Member
|
Doc part nextcloud/documentation#13907 |
provokateurin
requested changes
Dec 3, 2025
come-nc
approved these changes
Dec 4, 2025
Removed deprecated method 'runningOnMac' that checks if PHP is running on macOS. Signed-off-by: Josh <[email protected]>
Signed-off-by: Josh <[email protected]>
provokateurin
approved these changes
Dec 4, 2025
Contributor
|
This breaks MacOS CI as the error is now not ignored anymore on install: https://github.com/nextcloud/talk-ios/actions/runs/20001229346/job/57357971111?pr=2306 Needs adjustment at: (Leaving out the question if there’s a better way to do this ..) |
Member
|
Since we don't support macOS, you should also not use it in your CI this way 🙈 The right way is probably using a docker container for this in CI |
Contributor
|
Since macOS runner don’t support docker or nested virtualisation, this is the only way right now. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist
3. to review, feature component)stable32)Footnotes
Once we feel comfortable removing it. Not really sure if it's considered a public API or not. I guess kinda sorta. So
@deprecatedit (and changed its implementation to use the constant meanwhile too). ↩