-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
fix(settings): Improve mail test error handling and logging #56862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
szaimen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works!
Thanks a lot for fixing this!
|
/backport to stable32 |
|
/backport to stable31 |
|
@abhinavohri you don't need to update the branch unless there are conflicts. Please squash your commits and make sure the commit message follows https://www.conventionalcommits.org/en/v1.0.0/. |
Signed-off-by: Abhinav Ohri <[email protected]>
Signed-off-by: Abhinav Ohri <[email protected]>
|
@abhinavohri you need to adjust the tests to account for the new parameter you added to the class constructor. |
…r test Signed-off-by: Abhinav Ohri <[email protected]>
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
This PR improves the error handling and logging when testing email settings by showing informative error message on frontend and in the server logs.
Before
After
TODO
Checklist
3. to review, feature component)stable32)