Skip to content

Conversation

@abhinavohri
Copy link
Contributor

@abhinavohri abhinavohri commented Dec 5, 2025

Summary

This PR improves the error handling and logging when testing email settings by showing informative error message on frontend and in the server logs.

Before

image

After

image

TODO

  • ...

Checklist

@abhinavohri abhinavohri requested review from a team as code owners December 5, 2025 10:45
@abhinavohri abhinavohri requested review from icewind1991, nfebe, sorbaugh, szaimen and yemkareems and removed request for a team December 5, 2025 10:45
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works!

Thanks a lot for fixing this! ☺️

@szaimen
Copy link
Contributor

szaimen commented Dec 5, 2025

/backport to stable32

@szaimen
Copy link
Contributor

szaimen commented Dec 5, 2025

/backport to stable31

@szaimen szaimen added bug 3. to review Waiting for reviews regression labels Dec 5, 2025
@szaimen szaimen added this to the Nextcloud 33 milestone Dec 5, 2025
@provokateurin
Copy link
Member

@abhinavohri you don't need to update the branch unless there are conflicts. Please squash your commits and make sure the commit message follows https://www.conventionalcommits.org/en/v1.0.0/.

@provokateurin
Copy link
Member

@abhinavohri you need to adjust the tests to account for the new parameter you added to the class constructor.

@provokateurin provokateurin merged commit 6277ecf into nextcloud:master Dec 9, 2025
386 of 395 checks passed
@welcome
Copy link

welcome bot commented Dec 9, 2025

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

3 participants