-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
feat: automated appointment creation #56924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8f9bd94 to
b6f9404
Compare
b6f9404 to
e98decb
Compare
|
@ChristophWurst @kesselb @DerDreschner review please |
|
@ChristophWurst @kesselb @hamza221 review please |
f434863 to
0da2066
Compare
kesselb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Array shape needs an update; otherwise it won't match what's implemented in nextcloud/mail#12144.
lib/public/Calendar/IManager.php
Outdated
| * Handles a iMip message | ||
| * | ||
| * @param array{absent?: "create", recipient?: string} $options | ||
| * @param array{absent?: "create", absentCreateStatus?: string, recipient?: string} $options |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * @param array{absent?: "create", absentCreateStatus?: string, recipient?: string} $options | |
| * @param array{absent?: "create"|"ignore", absentCreateStatus?: "cancelled"|"confirmed"|"tentative", recipient?: string, ...} $options |
... tell Psalm to be a bit more relaxed about additional fields in the future ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. Done
Signed-off-by: SebastianKrupinski <[email protected]>
0da2066 to
16198d2
Compare
Summary
Checklist
3. to review, feature component)stable32)