Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
108 changes: 97 additions & 11 deletions core/src/components/UnifiedSearch/UnifiedSearchModal.vue
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
:label="t('core', 'Search apps, files, tags, messages') + '...'"
@update:value="debouncedFind" />
<div class="unified-search-modal__filters" data-cy-unified-search-filters>
<NcActions :menu-name="t('core', 'Places')" :open.sync="providerActionMenuIsOpen" data-cy-unified-search-filter="places">
<NcActions :open.sync="providerActionMenuIsOpen" :menu-name="t('core', 'Places')" data-cy-unified-search-filter="places">
<template #icon>
<IconListBox :size="20" />
</template>
Expand All @@ -43,7 +43,7 @@
{{ provider.name }}
</NcActionButton>
</NcActions>
<NcActions :menu-name="t('core', 'Date')" :open.sync="dateActionMenuIsOpen" data-cy-unified-search-filter="date">
<NcActions :open.sync="dateActionMenuIsOpen" :menu-name="t('core', 'Date')" data-cy-unified-search-filter="date">
<template #icon>
<IconCalendarRange :size="20" />
</template>
Expand Down Expand Up @@ -127,7 +127,8 @@
<h3 class="hidden-visually">
{{ t('core', 'Results') }}
</h3>
<div v-for="providerResult in results" :key="providerResult.id" class="result">
<!-- Filtered results section -->
<div v-for="providerResult in filteredResults" :key="providerResult.id" class="result">
<h4 :id="`unified-search-result-${providerResult.id}`" class="result-title">
{{ providerResult.name }}
</h4>
Expand All @@ -151,6 +152,36 @@
</NcButton>
</div>
</div>
<!-- Unfiltered results section -->
<template v-if="unfilteredResults.length > 0">
<div class="unified-search-modal__unfiltered-header">
<span class="unified-search-modal__unfiltered-label">{{ t('core', 'Partial matches') }}</span>
</div>
<div v-for="providerResult in unfilteredResults" :key="`unfiltered-${providerResult.id}`" class="result result--unfiltered">
<h4 :id="`unified-search-result-unfiltered-${providerResult.id}`" class="result-title">
{{ providerResult.name }}
</h4>
<ul class="result-items" :aria-labelledby="`unified-search-result-unfiltered-${providerResult.id}`">
<SearchResult v-for="(result, index) in providerResult.results"
:key="index"
v-bind="result" />
</ul>
<div class="result-footer">
<NcButton v-if="providerResult.results.length === providerResult.limit" variant="tertiary-no-background" @click="loadMoreResultsForProvider(providerResult)">
{{ t('core', 'Load more results') }}
<template #icon>
<IconDotsHorizontal :size="20" />
</template>
</NcButton>
<NcButton v-if="providerResult.inAppSearch" alignment="end-reverse" variant="tertiary-no-background">
{{ t('core', 'Search in') }} {{ providerResult.name }}
<template #icon>
<IconArrowRight :size="20" />
</template>
</NcButton>
</div>
</div>
</template>
</div>
</NcDialog>
</template>
Expand Down Expand Up @@ -335,6 +366,50 @@ export default defineComponent({
hasExternalResources() {
return this.providers.some(provider => provider.isExternalProvider)
},

hasContentFilters() {
return this.filters.some((filter) => filter.type === 'date' || filter.type === 'person')
},

filteredResults() {
const isInFolderAtRoot = (result) => {
if (result.id !== 'in-folder') {
return false
}
const path = result.extraParams?.path
return !path || path === '/' || path === ''
}

if (!this.hasContentFilters) {
return this.results.filter((result) => !isInFolderAtRoot(result))
}
return this.results.filter((result) => result.supportsActiveFilters === true && !isInFolderAtRoot(result))
},

filteredResultUrls() {
const urls = new Set()
this.filteredResults.forEach((provider) => {
provider.results.forEach((entry) => {
if (entry.resourceUrl) {
urls.add(entry.resourceUrl)
}
})
})
return urls
},

unfilteredResults() {
if (!this.hasContentFilters) {
return []
}
return this.results
.filter((result) => result.supportsActiveFilters === false)
.map((provider) => ({
...provider,
results: provider.results.filter((entry) => !this.filteredResultUrls.has(entry.resourceUrl)),
}))
.filter((provider) => provider.results.length > 0)
},
},

watch: {
Expand Down Expand Up @@ -473,6 +548,7 @@ export default defineComponent({
...provider,
results: response.data.ocs.data.entries,
limit: params.limit ?? 5,
supportsActiveFilters,
})

unifiedSearchLogger.debug('Unified search results:', { results: this.results, newResults })
Expand Down Expand Up @@ -553,10 +629,6 @@ export default defineComponent({
this.filters[existingPersonFilter].name = person.displayName
}

this.providers.forEach(async (provider, index) => {
this.providers[index].disabled = !(await this.providerIsCompatibleWithFilters(provider, ['person']))
})

this.debouncedFind(this.searchQuery)
unifiedSearchLogger.debug('Person filter applied', { person })
},
Expand Down Expand Up @@ -610,7 +682,6 @@ export default defineComponent({
for (let i = 0; i < this.filters.length; i++) {
if (this.filters[i].id === filter.id) {
this.filters.splice(i, 1)
this.enableAllProviders()
break
}
}
Expand Down Expand Up @@ -649,9 +720,6 @@ export default defineComponent({
this.filters.push(this.dateFilter)
}

this.providers.forEach(async (provider, index) => {
this.providers[index].disabled = !(await this.providerIsCompatibleWithFilters(provider, ['since', 'until']))
})
this.debouncedFind(this.searchQuery)
},
applyQuickDateRange(range) {
Expand Down Expand Up @@ -844,9 +912,27 @@ export default defineComponent({
align-items: center;
display: flex;
}

&--unfiltered {
opacity: 0.7;
}
}

}

&__unfiltered-header {
display: flex;
flex-direction: column;
gap: 2px;
margin-block: 16px 8px;
padding-block: 12px 0;
border-top: 1px solid var(--color-border);
}

&__unfiltered-label {
font-weight: bold;
color: var(--color-text-maxcontrast);
}
}

.filter-button__icon {
Expand Down
4 changes: 2 additions & 2 deletions dist/core-unified-search.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/core-unified-search.js.map

Large diffs are not rendered by default.

Loading