-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
fix: Reduce deprecation warnings in phpunit_nodb CI jobs #57020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
CalDAV part looks good |
Signed-off-by: Abhinav Ohri <[email protected]>
a86b40d to
2acd4b9
Compare
provokateurin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, just two minor things you could change.
apps/files_external/tests/LegacyDependencyCheckPolyfillTest.php
Outdated
Show resolved
Hide resolved
Signed-off-by: Abhinav Ohri <[email protected]>
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
This PR addresses the high volume of deprecation warnings appearing in the phpunit_nodb logs making it difficult to spot actual failures and potential issues.
Relevant links:
TestCase::getMockForAbstractClass()sebastianbergmann/phpunit#5241TestCasemethods for creating return stub configuration objects sebastianbergmann/phpunit#5423TestCase::getMockForTrait()sebastianbergmann/phpunit#5243Checklist
3. to review, feature component)stable32)