Skip to content

fix(FileSequence): Check whether temp dir still exists before using it #57092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
marcelklehr wants to merge 1 commit into from
Closed

fix(FileSequence): Check whether temp dir still exists before using it #57092

marcelklehr wants to merge 1 commit into from
+10 −4

Conversation

@marcelklehr
Copy link
Member

@marcelklehr marcelklehr commented Dec 15, 2025 •
edited
Loading

Summary

When running long running tasks in background jobs or unit tests the temp dir may be cleaned up and is then no longer available.

Checklist

@marcelklehr marcelklehr requested a review from a team as a code owner December 15, 2025 14:04
@marcelklehr marcelklehr requested review from Altahrim, ArtificialOwl, CarlSchwan and icewind1991 and removed request for a team December 15, 2025 14:04
@marcelklehr marcelklehr added the 3. to review Waiting for reviews label Dec 15, 2025
@marcelklehr marcelklehr added this to the Nextcloud 33 milestone Dec 15, 2025
@marcelklehr marcelklehr force-pushed the fix/file-sequence-temp-dir branch from 53759d5 to 934ad51 Compare December 15, 2025 14:21
@marcelklehr marcelklehr changed the title fix(FileSequence): Do not cache temp dir but use ITempManager directly fix(FileSequence): Check whether temp dir still exists before using it Dec 15, 2025
Altahrim
Altahrim reviewed Dec 15, 2025
View reviewed changes
Copy link
Collaborator

@Altahrim Altahrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized getTemporaryFolder have a random part so two processes will have different directory and the generator will probably generate non unique sequence numbers.

I hope this PR will fix the issue: #57094

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Altahrim Altahrim Altahrim left review comments

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan CarlSchwan is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

3 participants

@marcelklehr @Altahrim