Skip to content

[stable31] fix(dav): catch NotFound exception in UploadHome::childExists() #57103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshtrichards merged 1 commit into from
Dec 15, 2025
Merged

[stable31] fix(dav): catch NotFound exception in UploadHome::childExists() #57103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion apps/dav/lib/Upload/UploadHome.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
use OCP\Files\NotFoundException;
use OCP\IUserSession;
use Sabre\DAV\Exception\Forbidden;
use Sabre\DAV\Exception\NotFound;
use Sabre\DAV\ICollection;

class UploadHome implements ICollection {
Expand Down Expand Up @@ -49,7 +50,12 @@ public function getChildren(): array {
}

public function childExists($name): bool {
return !is_null($this->getChild($name));
try {
$this->getChild($name);
return true;
} catch (NotFound $e) {
return false;
}
}

public function delete() {
Expand Down
Loading