Skip to content

fix(taskprocessing): type cast for maxAgeSeconds in cleanup command #57111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
schmaller wants to merge 3 commits into from
Closed

fix(taskprocessing): type cast for maxAgeSeconds in cleanup command #57111

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6c42bae
type cast for maxAgeSeconds in cleanup command
schmaller Dec 16, 2025
209aef9
Merge branch 'master' into schmaller-patch-1
schmaller Jan 15, 2026
82b8f43
fix: Address review comment
marcelklehr Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/Command/TaskProcessing/Cleanup.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
}

protected function execute(InputInterface $input, OutputInterface $output): int {
$maxAgeSeconds = $input->getArgument('maxAgeSeconds') ?? Manager::MAX_TASK_AGE_SECONDS;
$maxAgeSeconds = (int) $input->getArgument('maxAgeSeconds') ?? Manager::MAX_TASK_AGE_SECONDS;

Check failure on line 49 in core/Command/TaskProcessing/Cleanup.php

View workflow job for this annotation

GitHub Actions / static-code-analysis

TypeDoesNotContainNull 

core/Command/TaskProcessing/Cleanup.php:49:66: TypeDoesNotContainNull: Cannot resolve types for $<tmp coalesce var>1462 - int does not contain null (see https://psalm.dev/090)

Check failure on line 49 in core/Command/TaskProcessing/Cleanup.php

View workflow job for this annotation

GitHub Actions / static-code-analysis

RedundantCondition 

core/Command/TaskProcessing/Cleanup.php:49:20: RedundantCondition: Type int for $<tmp coalesce var>1462 is never null (see https://psalm.dev/122)
$output->writeln('<comment>Cleanup up tasks older than ' . $maxAgeSeconds . ' seconds and the related output files</comment>');

$taskIdsToCleanup = [];
Expand Down
Loading