fix(IpNormalizer): Added inet_pton() check before bitwise operations
#57127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solracsf
requested review from
Altahrim,
CarlSchwan,
icewind1991 and
salmart-dev
and removed request for
a team
solracsf
force-pushed
the
addCheckBeforeBitwise
branch
from
5dbb7a2 to
b9d55ba
Compare
Signed-off-by: Git'Fellow <[email protected]>
Altahrim
approved these changes
Dec 16, 2025
susnux
approved these changes
Dec 17, 2025
Contributor
|
/backport to stable32 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added explicit check for
inet_pton()returningfalsebefore bitwise operations to prevent potential issues with invalid IPs + small optimizations.Checklist
3. to review, feature component)stable32)