fix(lib): include headers from OC\Template\Template as well in produced HTML #57133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed HTML Otherwise we only take those added through deprecated method C_Util::addHeader, not those of OC\Template\Template::addHeader, which does nothing Signed-off-by: Thomas Citharel <[email protected]>
tcitworld
requested review from
ArtificialOwl,
CarlSchwan and
icewind1991
and removed request for
a team
CarlSchwan
approved these changes
Dec 17, 2025
solracsf
approved these changes
Dec 17, 2025
come-nc
approved these changes
Dec 18, 2025
Contributor
|
/backport to stable32 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we only take those added through deprecated method
OC_Util::addHeader, not those ofOC\Template\Template::addHeader, which does nothing.Too complicated to add tests unfortunately.
Checklist
3. to review, feature component)stable32)