[stable29] multi-instance object store tweaks #57141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft

leftybournes wants to merge 6 commits into stable29-backports from leftybournes/fix/stable29-backports

+229 −114

Draft

[stable29] multi-instance object store tweaks #57141

refactor: validate object store and bucket before setting them

GitHub Advanced Security / Psalm succeeded Jan 9, 2026 in 15s

4 new alerts

New alerts in code changed by this pull request

4 notes

See annotations below for details.

View all branch alerts.

Annotations

Check notice on line 102 in apps/files/lib/Command/Object/Multi/Move.php

Code scanning / Psalm

RiskyTruthyFalsyComparison Note

Operand of type null|string contains type string, which can be falsy and truthy. This can cause possibly unexpected behavior. Use strict comparison instead.

Check notice on line 116 in apps/files/lib/Command/Object/Multi/Move.php

Code scanning / Psalm

PossiblyNullReference Note

Cannot call method getCache on possibly null value

Check notice on line 124 in apps/files/lib/Command/Object/Multi/Move.php

Code scanning / Psalm

DeprecatedMethod Note

The method OCP\DB\QueryBuilder\IQueryBuilder::execute has been marked as deprecated

Check notice on line 125 in apps/files/lib/Command/Object/Multi/Move.php

Code scanning / Psalm

PossiblyInvalidMethodCall Note

Cannot call method on possible int variable $result