-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
feat(userList): Allow to list all users #57179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
77748c1 to
b585280
Compare
Signed-off-by: Git'Fellow <[email protected]>
kesselb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐘
miaulalala
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the highest amount of users you've tested this with? I'm a bit worried about running out of memory - I think it would be wise to chunk the output to something like 500 or 1000 users per call to writeArrayInOutputFormat
|
@miaulalala You would still have all users in memory, no? |
11.768 in a public instance (using LDAP). |
|
Also please note that this PR is not different from something like |
--limit 0to disableuser:listlimit #57120Summary
Updated the limit option to allow
--limit=0for unlimited users listing.This PR simply passes null to underlying methods since
IUserManager::searchDisplayName()andIUserManager::getDisabledUsers()acceptnullfor the limit parameter.Checklist
3. to review, feature component)stable32)