feat (2fa): Add IStatelessProvider interface #57216
Open
+64
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michał Roszak <[email protected]>
Roszakos
requested review from
a team,
ChristophWurst,
miaulalala and
nickvergessen
as code owners
Roszakos
requested review from
ArtificialOwl,
come-nc,
icewind1991 and
provokateurin
and removed request for
a team
CarlSchwan
reviewed
Dec 23, 2025
| */ | ||
| interface IStatelessProvider extends IProvider { | ||
|
|
||
| public function isTwoFactorAuthEnabledForUser(IUser $user): bool; |
Member
There was a problem hiding this comment.
Suggested change
| public function isTwoFactorAuthEnabledForUser(IUser $user): bool; |
Doesn't add anything sine this method is from the parent interface
Author
There was a problem hiding this comment.
True. I added it, because i was concerned it may get removed from the IProvider interface in the future, since the DocBlock of the OC\Authentication\TwoFactorAuth\Manager::fixMissingProviderStates method says "todo: remove in Nextcloud 17 as by then all providers should have been updated" and it is the only usage of isTwoFactorAuthEnabledForUser method.
Anyway, i'm going to remove it from my interface, since there is no need for that at the moment.
Comment on lines
16
to
17
| * for user will be checked dynamically and not stored in the database. | ||
| */ |
Member
There was a problem hiding this comment.
Suggested change
| * for user will be checked dynamically and not stored in the database. | |
| */ | |
| * for user will be checked dynamically and not stored in the database. | |
| * @since 33.0.0 | |
| */ | |
| #[Implementable(since: '33.0.0')] |
Signed-off-by: Michał Roszak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds an
IStatelessProviderinterface. Per-user 2FA activation state for providers implementing this interface will not be stored in the database, thusisTwoFactorAuthEnabledForUsermethod will be called on every login attempt.Checklist
3. to review, feature component)stable32)