Skip to content

refactor(auth): Use $request->getCookie() instead of $_COOKIE #57287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
joshtrichards wants to merge 4 commits into
base: master
Choose a base branch
from
Open

refactor(auth): Use $request->getCookie() instead of $_COOKIE #57287

joshtrichards wants to merge 4 commits into from
+30 −6

Conversation

@joshtrichards
Copy link
Member

@joshtrichards joshtrichards commented Dec 29, 2025 •
edited
Loading

  • Resolves: #

Summary

Just a minor/tiny refinement for readability, maintainability, and robustness.

  • Use $request->getCookie() instead of $_COOKIE directly
  • Assign dependencies to variables up front for readability.
  • Note exceptions from each login method are possible and are not handled here / must be handled by callers.

TODO

  • ...

Checklist

@joshtrichards joshtrichards changed the title refactor(auth): improve robustness and readability of handleLogin refactor(auth):Use $request->getCookie() instead of $_COOKIE Dec 30, 2025
@joshtrichards joshtrichards added 3. to review Waiting for reviews feature: authentication ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Dec 30, 2025
@joshtrichards joshtrichards changed the title refactor(auth):Use $request->getCookie() instead of $_COOKIE refactor(auth): Use $request->getCookie() instead of $_COOKIE Dec 30, 2025
@joshtrichards joshtrichards marked this pull request as ready for review December 30, 2025 16:46
@joshtrichards joshtrichards requested a review from a team as a code owner December 30, 2025 16:46
@joshtrichards joshtrichards requested review from Altahrim, leftybournes, salmart-dev and yemkareems and removed request for a team December 30, 2025 16:46
@joshtrichards joshtrichards added this to the Nextcloud 33 milestone Dec 30, 2025
solracsf
solracsf reviewed Dec 30, 2025
View reviewed changes
This was referenced Jan 7, 2026
Merged
Open
@joshtrichards
refactor(auth): improve robustness and readability of handleLogin
9688be4 
- Use $request->getCookie() instead of $_COOKIE directly for consistency.
- Assign dependencies via variables up front for readability.
- Note exceptions from each login method is possible and are not handled here / must be handled by callers.

Just minor refinements to readability, maintainability, and some aspects of robustness.

Signed-off-by: Josh <[email protected]>
@joshtrichards
chore: fix typo
d0cb033 
Signed-off-by: Josh <[email protected]>
@joshtrichards
chore: fixup for lint
9378c2f 
Signed-off-by: Josh <[email protected]>
@joshtrichards
chore: updater per review input
fbac3a7 
Signed-off-by: Josh <[email protected]>
@joshtrichards joshtrichards force-pushed the jtr/refactor-base-handlelogin branch from 54fa444 to fbac3a7 Compare January 11, 2026 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@solracsf solracsf solracsf left review comments

@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim is a code owner automatically assigned from nextcloud/server-backend

@salmart-dev salmart-dev Awaiting requested review from salmart-dev salmart-dev is a code owner automatically assigned from nextcloud/server-backend

@yemkareems yemkareems Awaiting requested review from yemkareems yemkareems is a code owner automatically assigned from nextcloud/server-backend

@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

3. to review Waiting for reviews feature: authentication ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

3 participants

@joshtrichards @solracsf